Repository navigation
Conversation
- make TokenList::readBlockComment const - use the same parameter name in the constFoldUnaryNotPosNeg declaration and definition - rename the expandTrailingCalls callback parameter so it does not shadow gatherCall - use std::find_if in TokenList::fileIndex - selfcheck: suppress missingMemberCopy and constParameterReference, drop the unmatched missingIncludeSystem suppression Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmcppcheck
reviewed
Nov 20, 2026
dmcppcheck
left a comment
Contributor
There was a problem hiding this comment.
AI review
I found no problems. None of the source changes should change behaviour: the member initializers (bom{0}, isUtf16{false}), final on the stream classes, readBlockComment becoming const, the parameter renames and the std::find_if rewrite of fileIndex. readBlockComment is a private member, so making it const doesn't break the API that cppcheck uses. I couldn't run the new cppcheck workflow because the container has no network and no cppcheck.
Testing
make -j8 testrunner simplecpp CXXOPTS=-Werrorinpr/built with no warnings../testrunnerexited with 0.python3 run-tests.py: 176 tests, 0 failed, 21 skipped.python3 -m pytest integration_test.py: 128 passed../selfcheck.shexited with 0.- I built
base/and ran both binaries on everytestsuite/*.cfile. The outputs were the same. - A UTF-16LE file with a BOM (
#define A 1/A) gave1with both binaries. This checks the BOM and UTF-16 path that the new member initializers touch. - Not tested: the GitHub workflow itself. Without network access I couldn't clone or build cppcheck, so I couldn't check that tag 2.22.0 exists or that the self check passes with the given suppressions.
Automated review of e674f99 by Claude. The pull request was built and tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.